Skip to content

Move qkafka to bb-plugins / Log-triggers should only fire on TXN_APPLY #5103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

markhannum
Copy link
Contributor

bb-plugins will now json-ify and enqueue to kafka

@markhannum
Copy link
Contributor Author

/plugin-branch qkafka_plugins

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 5/604 tests failed ⚠.

The first 10 failing tests are:
fdb_compat
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
comdb2sys
incoherent_sql

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 3/604 tests failed ⚠.

The first 10 failing tests are:
osql_cleanup
remotecreate
incoherent_sql

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 1/604 tests failed ⚠.

The first 10 failing tests are:
incoherent_sql

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 1/604 tests failed ⚠.

The first 10 failing tests are:
incoherent_sql

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 1/604 tests failed ⚠.

The first 10 failing tests are:
incoherent_sql

chands10
chands10 previously approved these changes Apr 4, 2025
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 3/604 tests failed ⚠.

The first 10 failing tests are:
timepart_readonly
incoherent_sql
cldeadlock

Log-triggers should only fire on TXN_APPLY
Remove rdkafka libs & dependencies

Signed-off-by: Mark Hannum <[email protected]>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 2/604 tests failed ⚠.

The first 10 failing tests are:
timepart_readonly
sc_transactional_rowlocks_generated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants